Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for antialias and related subpixel order settings #291

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jhaygood86
Copy link

@jhaygood86 jhaygood86 commented Sep 4, 2021

This adds selectors for antialiasing, and if subpixel antialias is chosen, the subpixel order. It actually renders the labels within the mode buttons using the text settings selected so the user can see how it will look in advance and select the best looking version.

Example screenshot:

Screenshot from 2021-09-04 19-48-13

Fixes #288

@kdwk
Copy link

kdwk commented Sep 5, 2021

I think the spacing between the newly added options should be increased, because now the options seem too closely packed

@jhaygood86
Copy link
Author

Screenshot from 2021-09-05 19 10 06

Added some margins between the new settings.

@danirabbit danirabbit requested a review from a team September 8, 2021 19:37
@cassidyjames
Copy link
Contributor

My inclination with these additional text-related options is that we should move this layout over to a sidebar with:

  • Wallpaper
  • Appearance (or Style?)
  • Text (is that the best name?)
  • Dock & Panel
  • Multitasking

Does that make sense @elementary/ux?

@danirabbit
Copy link
Member

@cassidyjames yeah ultimately moving to a sidebar would be better imo. For the purposes of this PR, it would probably be good just to split the text options off into another tab

I'd also be inclined to use radios for these options instead of modebuttons

@jhaygood86
Copy link
Author

Screenshot from 2021-09-09 08-14-22

Added a new "Text" tab and moved text related settings there. Switched mode buttons to radio buttons for new settings

Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of design thoughts in no particular order (I'll also comment inline in the code where it makes sense and/or make a PR off this one):

  • Is there a valid reason to use "None" on modern hardware?

  • Perhaps we could simplify this to "Default" and "Subpixel" to be a little less technical; we don't really have to explain how anti-aliasing and subpixels work since users can choose it based on looks.

  • I wonder if we should include a longer-form example in a card (or a stack of labels if that's needed) above these options for a better visual

  • We could probably use an Infobar that appears on change to inform that apps will need to be re-opened to see changes, like we do in other plugs. This would clean up the amount of help copy.

  • I think labels on the left should be top-aligned if we're going with vertical radio buttons

  • We probably want to leave the subpixel settings visible but insensitive when unused so they don't seemingly randomly appear and change the flow of the page.

  • We can probably drop "Text" from each of these labels since the whole page is about "Text"

  • I wonder if a horizontal layout would work better for these radio options to take up less space?

  • I wonder if these should be under their own subheading with an example? Let me prototype that up 😄

@cassidyjames cassidyjames mentioned this pull request Sep 29, 2021
3 tasks
@danirabbit danirabbit mentioned this pull request Nov 18, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blurry fonts due to lack of anti-aliasing options
4 participants