Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a validator for election files #78

Open
jberkus opened this issue Oct 5, 2022 · 1 comment
Open

Need a validator for election files #78

jberkus opened this issue Oct 5, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jberkus
Copy link
Member

jberkus commented Oct 5, 2022

We need a script or test framework plugin that will validate election files, and prevent formatting errors. This validator could then be added as a presubmit test for organizations using elekto.

It would check for the following things:

  • all files are present
  • all YAML and MD files formatted correctly
  • IDs are valid
  • no MD formatting bugaboos, such as "@" characters
  • all required fields are present
@jberkus jberkus added enhancement New feature or request help wanted Extra attention is needed labels Oct 5, 2022
@upodroid
Copy link

upodroid commented Nov 3, 2022

On that note, elekto breaks down when an incorrectly formatted candidate-*.yaml is supplied. That needs to be fixed server side in addition to a script/linter that communities can run to ensure invalid files are not submitted.

The picture below was caused by merging knative/community#1193

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants