Missing yarn dependency?

[Jimbly]

package.json install script references yarn, but none of the dependencies install it, should it be added there? Running npm i minidump as instructed in the README generates the following error:

npm error command sh -c yarn submodule && node build.js
npm error sh: 1: yarn: not found

Running npm i yarn before trying to install minidump seems to help ([email protected] for [email protected] worked for me at the time of writing this report).

Happy to make a PR if it's as simple as adding it to package.json (but I admit I know nothing about yarn and if there's some reason you wouldn't want to do that as there often seems to be with overenthusiastic build systems ^_^)

[Jimbly]

Looking more closely, it appears the package as distributed via NPM has an entire copy of the submodules included inside it, so probably then yarn submodule && statement should just be removed from the preinstall script - this will also fix the error I see reported in another thread where, even with yarn installed, yarn submodule errors if there's no .git folder in the working directory. Looks like the submodule update should only be done when npm installing within a working directory of node-minidump, but not when running npm install minidump in another project, but it does not appear there's an explicit hook set up for that.