Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-system doesn't fail on CLI #3849

Open
3 tasks done
erickzhao opened this issue Feb 11, 2025 · 0 comments
Open
3 tasks done

check-system doesn't fail on CLI #3849

erickzhao opened this issue Feb 11, 2025 · 0 comments
Assignees

Comments

@erickzhao
Copy link
Member

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Forge version

7.6.1

Electron version

N/A

Operating system

All

Last known working Forge version

No response

Expected behavior

The system check runs, but no error is thrown and the output is collapsed so we aren't really doing anything here.

⚠ Checking your system
  ✔ Found [email protected]
  ✔ Found [email protected]
  ✖ Incompatible version of Yarn detected "0.28.4", must be in range >= 1.0.0

electron-forge:check-system checking system, create ~/.skip-forge-system-check to stop doing this +0ms
❯ Locating application
  electron-forge:project-resolver searching for project in: /Users/erick.zhao/Developer/dump/20250211-vanilla +0ms
  electron-forge:project-resolver package.json with forge dependency found in /Users/erick.zhao/Developer/dump/20250211-vanilla/package.json +1ms
✔ Locating application
❯ Loading configuration
  electron-forge:import-search searching [
  '@electron-forge/plugin-auto-unpack-natives',
  '/Users/erick.zhao/Developer/dump/20250211-vanilla/@electron-forge/plugin-auto-unpack-natives',
  '/Users/erick.zhao/Developer/dump/20250211-vanilla/node_modules/@electron-forge/plugin-auto-unpack-natives'
] relative to /Users/erick.zhao/Developer/dump/20250211-vanilla +0ms
  electron-forge:import-search testing @electron-forge/plugin-auto-unpack-natives +0ms
✔ Loading configuration
❯ Preparing native dependencies
✔ Preparing native dependencies
❯ Running generateAssets hook
✔ Running generateAssets hook
❯ Running preStart hook

Actual behavior

System check should fail or at least warn the user.

Steps to reproduce

The easiest way to reproduce this is to install an obsolete version of yarn.

npm install -g [email protected]
npm start

Additional information

No response

@erickzhao erickzhao self-assigned this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant