Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Structure of Examples #4

Open
amilajack opened this issue Oct 29, 2018 · 1 comment
Open

RFC: Structure of Examples #4

amilajack opened this issue Oct 29, 2018 · 1 comment

Comments

@amilajack
Copy link
Member

There's a number of ways that we can organize these examples. The current planned method is to structure the examples as a monorepo using lerna. After thinking through this more I think using git submodules might be a better solution. I expect that most users would only want to install the dependencies for the example they want to run. So if they use lerna and bootstrap all the lerna packages they'd be installing a lot of modules they don't need. Git submodules removes this issue by letting the user cd into the example they want to run and then installing the dependencies for that project.

Thoughts on this?

@vikr01
Copy link
Contributor

vikr01 commented Nov 30, 2018

This makes more sense to me, but I've often heard bad things about submodules. I say let's try it out and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants