Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Added to MiniMart on" date is date of last minimart upload for every cookbook #10

Open
edwardbartholomew opened this issue May 27, 2015 · 5 comments
Assignees

Comments

@edwardbartholomew
Copy link

The date displayed in the app next to every cookbook shows the date I have last uploaded cookbooks.
Not sure if this is issue with minimart, sync script, or user error?

@tapickell tapickell self-assigned this May 28, 2015
@tapickell
Copy link
Contributor

This date: Added to MiniMart on May 27, 2015,
What date would you expect @edwardbartholomew ?
I will look into updating to display what you think it should display.

@richardardrichard
Copy link
Contributor

This date should be the date that you downloaded the cookbook using Minimart. It would be found in the .minimart.json file in the directory of that specific cookbook.

@edwardbartholomew
Copy link
Author

Thanks for reply guys ... @richardardrichard do you mean download via the "Download" button or when we sync them? We're using a script like the "Example Jenkins Script" in the README. Every cookbook displays the date we last sync'ed ... regardless if cookbook was changed or not.

@richardardrichard
Copy link
Contributor

Yes, the timestamp should be when it was last synced... Just to clarify the folder in that directory is not being changed between runs, but the timestamp is being updated? If you were doing something like blowing away the directory of synced cookbooks every run, then this would be expected, otherwise this is a bug.

@edwardbartholomew
Copy link
Author

The example in the README, does have the cookbooks being deleted each run. Using --size-only option in the aws s3 sync command, will ignore timestamp and only update changed cookbooks. I have submitted a PR 11 to update the README. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants