From 4f3f52055656ecbc2d04016d282d23c950486b5c Mon Sep 17 00:00:00 2001 From: Adam Nelson Date: Wed, 19 Jul 2023 16:05:52 +0200 Subject: [PATCH] Fix incomplete release instructions in CONTRIBUTING --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b4821da..8a0640b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -103,7 +103,7 @@ the `release.toml` file. To perform a release, check out `master` and do the f - `cargo release` will make two commits in your local repo, one making a new release tagged with `vX.Y.Z` where X, Y, and Z are the semver components of the new release, and it will also update `master` with a new `-dev` version that is one patch level higher than the released version. -- To actually perform the release, do a `git push --tags` to push all of the changes made by `cargo-release` +- To actually perform the release, do a `git push && git push --tags` to push all of the changes made by `cargo-release` - Monitor the progress of the release activites in Github Actions. Sometimes these fail and then it's a huge PITA since you in effect need to undo the release (if the failure happened before the publish to crates.io), or yank the crates.io release and make a new patch release which hopefully fixes the problem.