Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] Fix leading wildcard discover link generation #193337

Closed
kdelemme opened this issue Sep 18, 2024 · 1 comment · Fixed by #193362
Closed

[SLO] Fix leading wildcard discover link generation #193337

kdelemme opened this issue Sep 18, 2024 · 1 comment · Fixed by #193362
Assignees
@kdelemme
Labels
Team:obs-ux-management Observability Management User Experience Team

Comments

@kdelemme
Copy link
Contributor

Summary

Fix the discover link when es queries contain a leading wildcard

@KarthikaAnbazagan I've found the issue.

In 8.14 we introduce a link to Discover from our charts displayed in the SLO details page. The way to build the link was to rely on an internal library that had an optional allowLeadingWildcards configuration with a default false value. We were not providing the allowLeadingWildcards value based on the Kibana settings, so it was always set to false. Even if the user had enabled the settings.
Thus, the page loading error in 8.14

I'm going to work on a fix but in the meantime, they should avoid leading wildcards in the good and bad queries. They can though use it in the filter query. Maybe they can rewrite their indicator configuration differently.

Originally posted by @kdelemme in #4932
@kdelemme kdelemme self-assigned this Sep 18, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 18, 2024
@lukasolson lukasolson added Team:obs-ux-management Observability Management User Experience Team and removed needs-team Issues missing a team label labels Sep 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kdelemme kdelemme mentioned this issue Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdelemme kdelemme

Labels
Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(slo): use correct uisettings kdelemme/kibana
3 participants
@lukasolson @kdelemme @elasticmachine