Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] CSV export does not respect columns order from table #164413

Closed
dej611 opened this issue Aug 22, 2023 · 5 comments · Fixed by #174994
Closed

[Lens] CSV export does not respect columns order from table #164413

dej611 opened this issue Aug 22, 2023 · 5 comments · Fixed by #174994
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dej611
Copy link
Contributor

dej611 commented Aug 22, 2023

Describe the feature:

When exporting a Lens table as CSV, the order of columns visualized in the Lens table is not respected within the CSV file content.

Describe a specific use case for the feature:
While the content is equivalent this could be annoying when the user has some script that rely on some order of the columns.

@dej611 dej611 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@timductive timductive added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Aug 23, 2023
@stratoula
Copy link
Contributor

@dej611 this seems similar with this right? #164055

@dej611
Copy link
Contributor Author

dej611 commented Aug 28, 2023

Yes, similar. But here I reproduced without any split metric dimension, so it's a general case.

@dej611 dej611 self-assigned this Jan 17, 2024
dej611 added a commit that referenced this issue Jan 23, 2024
## Summary

Fixes #160719 and #164413

This PR contains some work about Lens datatable, here's a short list:

* moved out the sorting logic of the datatable into an independent
package: `@kbn/sort-predicates`
* leverage the EUI Datagrid `schemaDetectors` for the table rows sorting
* apply datatable columns sorting also to the CSV exporter

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
## Summary

Fixes elastic#160719 and elastic#164413

This PR contains some work about Lens datatable, here's a short list:

* moved out the sorting logic of the datatable into an independent
package: `@kbn/sort-predicates`
* leverage the EUI Datagrid `schemaDetectors` for the table rows sorting
* apply datatable columns sorting also to the CSV exporter

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@dej611 dej611 removed their assignment Apr 18, 2024
@ikishorkumar
Copy link

So when we receive that fixed as our clients need it!

@nickofthyme
Copy link
Contributor

@ikishorkumar Sorry for the delayed response this was fixed in #174994 and released in v8.13.0 but not properly linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants