Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGSEGV running git spr update -c 1 #420

Open
yang opened this issue Jul 30, 2024 · 1 comment · May be fixed by #423
Open

SIGSEGV running git spr update -c 1 #420

yang opened this issue Jul 30, 2024 · 1 comment · May be fixed by #423
Labels
bug Something isn't working

Comments

@yang
Copy link

yang commented Jul 30, 2024

It's updating an existing PR.

$ git spr update -c 1
...
> github update 45455 : Do stuff
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x102fd6b58]

goroutine 35 [running]:
github.com/ejoffe/spr/github/githubclient.formatStackMarkdown({{0x140000aa1a1, 0x8}, {0x140000aa0df, 0x28}, {0x140000aa167, 0x26}, {0x1030df080, 0x0}, 0x0}, {0x140002eb940, ...}, ...)
	/Users/runner/work/spr/spr/github/githubclient/client.go:431 +0x128
github.com/ejoffe/spr/github/githubclient.formatBody({{0x140000aa1a1, 0x8}, {0x140000aa0df, 0x28}, {0x140000aa167, 0x26}, {0x1030df080, 0x0}, 0x0}, {0x140002eb940?, ...}, ...)
	/Users/runner/work/spr/spr/github/githubclient/client.go:458 +0x74
github.com/ejoffe/spr/github/githubclient.(*client).UpdatePullRequest(0x1400000ca68, {0x1031c04f0, 0x1034dd500}, {0x1031c0410, 0x1400000ca38}, {0x140002eb940, 0x2, 0x2}, 0x14000355a40, {{0x140000aa1a1, ...}, ...}, ...)
	/Users/runner/work/spr/spr/github/githubclient/client.go:549 +0x340
github.com/ejoffe/spr/spr.(*stackediff).UpdatePullRequests.func2(0x140001b8a80?)
	/Users/runner/work/spr/spr/spr/spr.go:242 +0xcc
created by github.com/ejoffe/spr/spr.(*stackediff).UpdatePullRequests in goroutine 1
	/Users/runner/work/spr/spr/spr/spr.go:240 +0x108c

Dropping the -c 1 has no issue.

VERSION: fork of 0.14.9 : 2024-03-15T19:34:25Z : e2eb7866
@chriscz
Copy link
Collaborator

chriscz commented Aug 22, 2024

Ran into the same issue now. I will try to have a look this weekend.

@chriscz chriscz linked a pull request Aug 22, 2024 that will close this issue
Open
@chriscz chriscz added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix segfault when running update with --count=1 on a stack with more than one commit chriscz/spr
2 participants
@yang @chriscz