Merge pull request #50 from eigr/feat/tests_continuation

Centralize protos and cluster, test helper structure and ecto sandbox

Author: sleipnir

apps/activator/mix.exs

@@ -27,7 +27,7 @@ defmodule Activators.MixProject do
   # Run "mix help deps" to learn about dependencies.
   defp deps do
     [
-      {:protos, "~> 0.1", in_umbrella: true},
+      {:spawn, "~> 0.1", in_umbrella: true},
       {:actors, "~> 0.1", in_umbrella: true},
       {:cloudevents, "~> 0.6.1"},
       {:hackney, "~> 1.9"}

apps/activator_grpc/mix.exs

@@ -30,7 +30,7 @@ defmodule ActivatorGRPC.MixProject do
     [
       {:activator, "~> 0.1", in_umbrella: true},
       {:actors, "~> 0.1", in_umbrella: true},
-      {:cluster, "~> 0.1", in_umbrella: true},
+      {:spawn, "~> 0.1", in_umbrella: true},
       {:metrics_endpoint, "~> 0.1", in_umbrella: true}
     ]
   end

apps/activator_http/mix.exs

@@ -30,7 +30,7 @@ defmodule ActivatorHTTP.MixProject do
     [
       {:activator, "~> 0.1", in_umbrella: true},
       {:actors, "~> 0.1", in_umbrella: true},
-      {:cluster, "~> 0.1", in_umbrella: true},
+      {:spawn, "~> 0.1", in_umbrella: true},
       {:metrics_endpoint, "~> 0.1", in_umbrella: true},
       {:bakeware, "~> 0.2"},
       {:bandit, "~> 0.5"}

apps/activator_kafka/mix.exs

@@ -30,7 +30,7 @@ defmodule ActivatorKafka.MixProject do
     [
       {:activator, "~> 0.1", in_umbrella: true},
       {:actors, "~> 0.1", in_umbrella: true},
-      {:cluster, "~> 0.1", in_umbrella: true},
+      {:spawn, "~> 0.1", in_umbrella: true},
       {:metrics_endpoint, "~> 0.1", in_umbrella: true},
       {:broadway_kafka, "~> 0.3"},
       {:bakeware, "~> 0.2"},

apps/activator_pubsub/mix.exs

@@ -30,7 +30,7 @@ defmodule ActivatorPubSub.MixProject do
     [
       {:activator, "~> 0.1", in_umbrella: true},
       {:actors, "~> 0.1", in_umbrella: true},
-      {:cluster, "~> 0.1", in_umbrella: true},
+      {:spawn, "~> 0.1", in_umbrella: true},
       {:metrics_endpoint, "~> 0.1", in_umbrella: true},
       {:bakeware, "~> 0.2"},
       {:bandit, "~> 0.5"}

apps/activator_rabbitmq/mix.exs

@@ -29,7 +29,7 @@ defmodule ActivatorRabbitMQ.MixProject do
   defp deps do
     [
       {:activator, "~> 0.1", in_umbrella: true},
-      {:cluster, "~> 0.1", in_umbrella: true},
+      {:spawn, "~> 0.1", in_umbrella: true},
       {:metrics_endpoint, "~> 0.1", in_umbrella: true},
       {:bakeware, "~> 0.2"},
       {:bandit, "~> 0.5"},

apps/activator_sqs/mix.exs

@@ -30,7 +30,7 @@ defmodule ActivatorSQS.MixProject do
     [
       {:activator, "~> 0.1", in_umbrella: true},
       {:actors, "~> 0.1", in_umbrella: true},
-      {:cluster, "~> 0.1", in_umbrella: true},
+      {:spawn, "~> 0.1", in_umbrella: true},
       {:metrics_endpoint, "~> 0.1", in_umbrella: true},
       {:bakeware, "~> 0.2"},
       {:bandit, "~> 0.5"},

apps/actors/mix.exs

@@ -28,8 +28,7 @@ defmodule Actors.MixProject do
   # Run "mix help deps" to learn about dependencies.
   defp deps do
     [
-      {:cluster, "~> 0.1", in_umbrella: true},
-      {:protos, "~> 0.1", in_umbrella: true},
+      {:spawn, "~> 0.1", in_umbrella: true},
       {:statestores, "~> 0.1", in_umbrella: true},
       {:cowlib, "~> 2.9", override: true},
       {:decimal, "~> 2.0", override: true},

apps/actors/test/actors/actors_test.exs

@@ -1,13 +1,23 @@
 defmodule ActorsTest do
-  use ExUnit.Case, async: false
-  use Actors.MockTest
-  import Actors.FactoryTest
+  use Actors.DataCase, async: false
 
   alias Eigr.Functions.Protocol.ActorInvocationResponse
   alias Eigr.Functions.Protocol.Actors.ActorState
   alias Eigr.Functions.Protocol.RegistrationResponse
 
-  doctest Actors
+  setup_all do
+    actor_name = "global_actor_test"
+
+    actor = build_actor(name: actor_name)
+    actor_entry = build_actor_entry(name: actor_name)
+    registry = build_registry_with_actors(actors: [actor_entry])
+    system = build_system(name: "global_sytem_name", registry: registry)
+
+    request = build_registration_request(actor_system: system)
+    {:ok, %RegistrationResponse{}} = Actors.register(request)
+
+    %{system: system, actor: actor}
+  end
 
   describe "register/1" do
     test "register actors for a system" do
@@ -39,7 +49,7 @@ defmodule ActorsTest do
   end
 
   describe "invoke/2" do
-    test "invoke function for a newly registered actor" do
+    test "invoke actor function for a newly registered actor" do
       actor_name = "actor_test_" <> Ecto.UUID.generate()
 
       actor = build_actor(name: actor_name)
@@ -62,5 +72,82 @@ defmodule ActorsTest do
       assert {:ok, %ActorInvocationResponse{actor_name: ^actor_name}} =
                Actors.invoke(invoke_request)
     end
+
+    test "invoke actor function for a already registered actor in another node", ctx do
+      %{system: system, actor: actor} = ctx
+      actor_name = actor.name
+
+      invoke_request = build_invocation_request(system: system, actor: actor)
+
+      host_invoke_response =
+        build_host_invoke_response(actor_name: actor_name, system_name: system.name)
+
+      mock_invoke_host_actor_with_ok_response(host_invoke_response)
+
+      assert {:ok, %ActorInvocationResponse{actor_name: ^actor_name}} =
+               Actors.invoke(invoke_request)
+
+      state =
+        Actors.Protos.ChangeNameResponseTest.new(
+          status: :NAME_ALREADY_TAKEN,
+          new_name: "new_name"
+        )
+        |> any_pack!
+
+      host_invoke_response =
+        build_host_invoke_response(actor_name: actor_name, system_name: system.name, state: state)
+
+      mock_invoke_host_actor_with_ok_response(host_invoke_response)
+
+      # wait for nodes to sync
+      Process.sleep(100)
+
+      assert {:ok,
+              %ActorInvocationResponse{actor_name: ^actor_name, updated_context: updated_context}} =
+               Spawn.NodeHelper.rpc(:"[email protected]", Actors, :invoke, [
+                 invoke_request
+               ])
+
+      assert %Actors.Protos.ChangeNameResponseTest{status: :NAME_ALREADY_TAKEN} =
+               any_unpack!(updated_context.state, Actors.Protos.ChangeNameResponseTest)
+    end
+
+    test "invoke function for a new actor without persistence in another node", _ctx do
+      actor_name = "actor_not_persistent"
+
+      actor = build_actor(name: actor_name, persistent: false)
+      actor_entry = build_actor_entry(name: actor_name, actor: actor)
+      registry = build_registry_with_actors(actors: [actor_entry])
+      system = build_system(name: "any_system_whatever", registry: registry)
+
+      request = build_registration_request(actor_system: system)
+      {:ok, %RegistrationResponse{}} = Actors.register(request)
+
+      invoke_request = build_invocation_request(system: system, actor: actor)
+
+      state =
+        Actors.Protos.ChangeNameResponseTest.new(
+          status: :OK,
+          new_name: "new_name"
+        )
+        |> any_pack!
+
+      host_invoke_response =
+        build_host_invoke_response(actor_name: actor_name, system_name: system.name, state: state)
+
+      mock_invoke_host_actor_with_ok_response(host_invoke_response)
+
+      # wait for nodes to sync
+      Process.sleep(100)
+
+      assert {:ok,
+              %ActorInvocationResponse{actor_name: ^actor_name, updated_context: updated_context}} =
+               Spawn.NodeHelper.rpc(:"[email protected]", Actors, :invoke, [
+                 invoke_request
+               ])
+
+      assert %Actors.Protos.ChangeNameResponseTest{status: :OK} =
+               any_unpack!(updated_context.state, Actors.Protos.ChangeNameResponseTest)
+    end
   end
 end

apps/actors/test/support/data_case.ex

@@ -0,0 +1,16 @@
+defmodule Actors.DataCase do
+  @moduledoc false
+
+  use ExUnit.CaseTemplate
+
+  using do
+    quote do
+      use Spawn.SandboxHelper, repos: [Statestores.Util.load_repo()]
+
+      use Actors.MockTest
+      import Actors.FactoryTest
+
+      import Spawn.DataCase
+    end
+  end
+end

apps/actors/test/support/factory.ex

@@ -81,7 +81,7 @@ defmodule Actors.FactoryTest do
   def build_actor(attrs \\ []) do
     Actor.new(
       name: attrs[:name] || "#{Faker.Superhero.name()} #{Faker.StarWars.character()}",
-      persistent: attrs[:persistent] || false,
+      persistent: Keyword.get(attrs, :persistent, true),
       state: attrs[:state] || build_actor_state(),
       snapshot_strategy: attrs[:snapshot_strategy] || build_actor_snapshot_strategy(),
       deactivate_strategy: attrs[:deactivate_strategy] || build_actor_deactivate_strategy()
@@ -90,12 +90,7 @@ defmodule Actors.FactoryTest do
 
   def build_actor_state(attrs \\ []) do
     state =
-      Any.new(
-        type_url: get_type_url(Actors.Protos.StateTest),
-        value:
-          Actors.Protos.StateTest.new(name: "example_state_name_#{Faker.Superhero.name()}")
-          |> Actors.Protos.StateTest.encode()
-      )
+      any_pack!(Actors.Protos.StateTest.new(name: "example_state_name_#{Faker.Superhero.name()}"))
 
     ActorState.new(state: Any.new(attrs[:state] || state))
   end
@@ -128,12 +123,7 @@ defmodule Actors.FactoryTest do
 
   def build_host_invoke_response(attrs \\ []) do
     state =
-      Any.new(
-        type_url: get_type_url(Actors.Protos.ChangeNameTest),
-        value:
-          Actors.Protos.ChangeNameResponseTest.new(status: :OK, new_name: "new_name")
-          |> Actors.Protos.ChangeNameTest.encode()
-      )
+      Actors.Protos.ChangeNameResponseTest.new(status: :OK, new_name: "new_name") |> any_pack!
 
     context = Eigr.Functions.Protocol.Context.new(state: attrs[:state] || state)
 
@@ -145,6 +135,17 @@ defmodule Actors.FactoryTest do
     )
   end
 
+  def any_pack!(record) do
+    Any.new(
+      type_url: get_type_url(record.__struct__),
+      value: apply(record.__struct__, :encode, [record])
+    )
+  end
+
+  def any_unpack!(any_record, builder) do
+    builder.decode(any_record.value)
+  end
+
   defp get_type_url(type) do
     parts =
       type

apps/actors/test/test_helper.exs

@@ -3,4 +3,15 @@ Mimic.copy(Actors.Node.Client)
 ExUnit.start()
 Faker.start()
 
-Spawn.Cluster.Node.Registry.start_link(%{})
+Spawn.InitializerHelper.setup()
+
+Actors.Supervisors.ProtocolSupervisor.start_link(%{})
+Actors.Supervisors.EntitySupervisor.start_link(%{})
+
+node = Spawn.NodeHelper.spawn_peer("spawn_actors_node")
+
+Spawn.NodeHelper.rpc(node, Spawn.InitializerHelper, :setup, [])
+Spawn.NodeHelper.rpc(node, Actors.Supervisors.ProtocolSupervisor, :start_link, [%{}])
+Spawn.NodeHelper.rpc(node, Actors.Supervisors.EntitySupervisor, :start_link, [%{}])
+
+IO.puts("Nodes connected: #{inspect(Node.list())}")

apps/cluster/lib/cluster.ex

@@ -28,7 +28,7 @@ defmodule Operator.MixProject do
   # Run "mix help deps" to learn about dependencies.
   defp deps do
     [
-      {:cluster, "~> 0.1", in_umbrella: true},
+      {:spawn, "~> 0.1", in_umbrella: true},
       {:metrics_endpoint, "~> 0.1", in_umbrella: true},
       {:bandit, "~> 0.5"},
       {:bonny, "~> 0.5"},