Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unflattener should not include optional ENTRY instance (height in this example) #162

Open
6 tasks
bjornna opened this issue Dec 27, 2020 · 1 comment
Open
6 tasks
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bjornna
Copy link
Contributor

bjornna commented Dec 27, 2020

Configuration information

  • openEHR_SDK version: develop-SNAPSHOT

Steps to reproduce

Create a OPT for vital signs, i.e. https://tools.openehr.org/designer/#/viewer/shared/Pz9zaGFyZWRJZD0xJDY5Nzc2M2FhNzM5YTQ2NDRiNGM1YmJmYjE4ZmM3ZDlk

Add one entry, i.e. a body temperature and run the unflattener

Example in this dummy test: https://github.com/bjornna/openfhiehr/blob/main/src/test/java/no/bifrost/openfhiehr/BodyTempTest.java

Actual result

An instance of height/lenght was added to the composition.

Expected result (Acceptance Criteria)

I expect only the explict added entries to be included in the generated Composition and not the height/lenght

I assume its because height/lenght has a mandatory element "height". But the archetype is optional in the OPT.

Definition of Done

  • The defect is checked by an unit or an integration test (Robot)
  • Merge Request approved
  • Unit tests passed
  • Build without errors
  • Release notes prepared
  • No additional runtime warnings
@bjornna bjornna added the bug Something isn't working label Dec 27, 2020
@birgerhaarbrandt birgerhaarbrandt added this to the 1.0 milestone Jan 7, 2021
@stefanspiska
Copy link
Contributor

@bjornna I can not access the opt. Can you please attach the file to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants