Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance github downloader logic #25

Open
efrecon opened this issue Sep 18, 2020 · 0 comments
Open

Enhance github downloader logic #25

efrecon opened this issue Sep 18, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@efrecon
Copy link
Owner

efrecon commented Sep 18, 2020

Some projects, e.g. bashtop, see #22, do not make releases through the gitthub UI (or the command-line equivalents such as gh or hub), but simply through pushing annotated tags. For such projects, the release API will return an empty JSON array, meaning the assets to get is a copy of the source code. These are pointed at by the tags api and techniques similar to what is used for releases can be used to get to the binary. In those cases, the implementation should perhaps account for a build step, e.g. running make in some form.

@efrecon efrecon added the enhancement New feature or request label Sep 18, 2020
@efrecon efrecon self-assigned this Sep 18, 2020
@efrecon efrecon mentioned this issue Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant