Katebygrace/collect metrics secrets #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katebygrace
force-pushed
the
katebygrace/collect-metrics-secrets
branch
2 times, most recently
from
0c9d5df to
ea50b3f
Compare
| @@ -10,10 +10,19 @@ source "${PYTHON_VENV}/bin/activate" | |||
| cd $WORKSPACE/analytics-tools/snowflake | |||
| make requirements | |||
|
|
|||
| python3 secrets-manager.py -w -n analytics-secure/snowflake/rsa_key_snowflake_task_automation_user.p8 -v rsa_key_snowflake_task_automation_user | |||
| python3 secrets-manager.py -w -n analytics-secure/snowflake/rsa_key_passphrase_snowflake_task_ automation_user -v rsa_key_passphrase_snowflake_task_automation_user | |||
There was a problem hiding this comment.
Is the underscore intentional here ?
rsa_key_passphrase_snowflake_task_
HassanJaveed84
approved these changes
May 10, 2024
JIRA:CLOUDSEC-12
katebygrace
force-pushed
the
katebygrace/collect-metrics-secrets
branch
from
ea50b3f to
31fa59d
Compare
the-real-cphillips
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove calls to other secrets manager scripts in jenkins
Remove calls to secrets manager scripts in shell script
Check and remove the key_path and passphrase_path
Run python script x2
Change calls to python script to include key_file and passphrase_file (note slashes)
rm files
Review vars in analytics secure if there are any others that need to be set
job-configs/SNOWFLAKE_COLLECT_METRICS_JOB_EXTRA_VARS.yaml
SECURE_BRANCH: 'origin/master'