Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example of actual authenticated state in example app #231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Apr 6, 2022

Updated the example app to include the actual authenticated state of whether the user is logged in, in order to have a quick testing ground for QA'ing the integration with @edx/frontend-enterprise-utils.

image

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71cdbab) 71.94% compared to head (eb34582) 71.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   71.94%   71.94%           
=======================================
  Files          51       51           
  Lines         802      802           
  Branches      156      156           
=======================================
  Hits          577      577           
  Misses        215      215           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz force-pushed the astankiewicz/show-actual-auth-state-in-example-app branch from 6913f62 to b358ec3 Compare April 6, 2022 04:09
@Mashal-m
Copy link
Contributor

Hey @adamstankiewicz, What is the current status of this PR, is it ready to review and merge?
Could you please resolve conflicts?

@adamstankiewicz adamstankiewicz force-pushed the astankiewicz/show-actual-auth-state-in-example-app branch from b358ec3 to eb34582 Compare January 10, 2024 15:18
@adamstankiewicz
Copy link
Member Author

Hey @adamstankiewicz, What is the current status of this PR, is it ready to review and merge? Could you please resolve conflicts?

Hi @Mashal-m. I've resolved merge conflicts and updated the PR. Suitable for review at your leisure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants