fix: fixing 500 error with null values

fix: fixing 500 error with null values

Author: kiram15

enterprise_access/apps/api/serializers/customer_billing.py

@@ -283,16 +283,19 @@ class StripeSubscriptionPlanInfoResponseSerializer(serializers.Serializer):
     Response serializer for response body from GET /api/v1/stripe-event-summary/get-stripe-subscription-plan-info
     """
     upcoming_invoice_amount_due = serializers.CharField(
+        allow_null=True,
         required=False,
         help_text='Upcoming invoice amount due related to this event/subscription',
     )
 
     currency = serializers.CharField(
+        allow_null=True,
         required=False,
         help_text='Three-letter ISO currency code associated with the subscription.',
     )
 
     canceled_date = serializers.DateTimeField(
+        allow_null=True,
         required=False,
         help_text='Timestamp when the subscription is scheduled to be canceled',
     )

enterprise_access/apps/api/v1/views/customer_billing.py

@@ -624,7 +624,6 @@ def get_stripe_subscription_plan_info(self, request, *args, **kwargs):
         subscription_plan_uuid = self.request.query_params.get('subscription_plan_uuid')
         if not subscription_plan_uuid:
             raise exceptions.ValidationError(detail='subscription_plan_uuid query param is required')
-        subscription_plan_uuid = self.request.query_params.get('subscription_plan_uuid')
         created_event_summary = StripeEventSummary.objects.filter(
             event_type='customer.subscription.created',
             subscription_plan_uuid=subscription_plan_uuid,
@@ -650,8 +649,9 @@ def get_stripe_subscription_plan_info(self, request, *args, **kwargs):
                 'canceled_date': canceled_date,
             },
         )
-        if not (subscription_plan_uuid and (updated_event_summary or created_event_summary)):
-            return Response({})
-        if not response_serializer.is_valid():
-            return HttpResponseServerError()
+        if not subscription_plan_uuid:
+            raise exceptions.NotFound("No associated subscription plan uuid was found")
+        if not (updated_event_summary or created_event_summary):
+            raise exceptions.NotFound("No Stripe subscription data found for this plan")
+        response_serializer.is_valid(raise_exception=True)
         return Response(response_serializer.data, status=status.HTTP_200_OK)