chore: Elm theme improvements for modals and alerts #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnr
approved these changes
Oct 22, 2024
shafqat-muneer
requested changes
Oct 25, 2024
| self?.analytics.externalLinkOpenAction( | ||
| url: url.absoluteString, | ||
| screen: self?.sourceScreen.value ?? "", | ||
| action: "continue" |
There was a problem hiding this comment.
Can we use CoreLocalization.Webview.Alert.continue here?
There was a problem hiding this comment.
It's for the analytics, if we use the localized string then it will be different as per the language and it will be hard to group the event based on value.
| self?.analytics.externalLinkOpenAction( | ||
| url: url.absoluteString, | ||
| screen: self?.sourceScreen.value ?? "", | ||
| action: "cancel" |
There was a problem hiding this comment.
Can we use CoreLocalization.Webview.Alert.cancel?
shafqat-muneer
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira Ticket: LEARNER-10148