fix: iOS 18 Toggle tap gesture #98

rnr · 2024-11-20T16:49:53Z

In iOS 18, parental view blocks the tap gesture for Toogle, and tapping only works in a small area above Toggle. Drag action doesn't work too. Added priority for the Toggle gestures (both tap and drag).

Before	After
Screen.Recording.2024-11-20.at.17.41.41.mov	Screen.Recording.2024-11-20.at.17.37.31.mov

shafqat-muneer · 2024-11-20T19:03:45Z

@rnr Based on my observations, this issue seems to be specific to the simulator and occurs when the trackpad is clicked on a Mac. If the user uses a tap gesture on the trackpad, the issue does not appear, even in the simulator.

It's great that this scenario has been addressed. However, there are two additional places where the Toggle control is being used. Could you kindly address it there as well?

- CourseDatesView
- DatesAndCalendarView

rnr · 2024-11-21T12:21:14Z

@rnr Based on my observations, this issue seems to be specific to the simulator and occurs when the trackpad is clicked on a Mac. If the user uses a tap gesture on the trackpad, the issue does not appear, even in the simulator.

It's great that this scenario has been addressed. However, there are two additional places where the Toggle control is being used. Could you kindly address it there as well?
- CourseDatesView
- DatesAndCalendarView

@shafqat-muneer
I have this issue on my iPhone with iOS 18.1 when build from 2U/develop right now - so it's not Simulator or trackpad bug.
And you are right CourseDatesView has this bug too since .onTapGesture is using there. Let me fix it. Thank you

shafqat-muneer · 2024-11-21T12:49:45Z

@shafqat-muneer I have this issue on my iPhone with iOS 18.1 when build from 2U/develop right now - so it's not Simulator or trackpad bug. And you are right CourseDatesView has this bug too since .onTapGesture is using there. Let me fix it. Thank you

Got it. It's great that the issue has been identified and fixed 🎉. I tested it on a device running OS 17.3 but will also check on the latest OS version.

Course/Course/Presentation/Subviews/CourseVideoDownloadBarView/CourseVideoDownloadBarView.swift

@@ -135,13 +135,15 @@ struct CourseVideoDownloadBarView: View {
        Toggle("", isOn: .constant(viewModel.isOn))


Course/Course/Presentation/Dates/CourseDatesView.swift

@@ -462,9 +462,16 @@ struct CalendarSyncView: View {
                Toggle("", isOn: .constant(viewModel.isOn))


rnr · 2024-11-21T13:29:48Z

@shafqat-muneer
PR is ready for another pass.
Thank you

shafqat-muneer

LGTM 👍

* fix: added priority for toggle tap gesture * fix: fixed tap and drag actions for Toggle --------- Co-authored-by: Anton Yarmolenko <[email protected]>

* chore: add video and discussion analytics (#93) * fix: fixes after merge, deleted IAP parts * chore: changed dependency version, deleted unused analytics part * chore: regenerate mocks * chore: In app ratings modal and profile picture picture sheet UI improvements (#94) * chore: show subtitles for videos in full-screen mode (#97) * fix: after merge * fix: iOS 18 Toggle tap gesture (#98) * fix: added priority for toggle tap gesture * fix: fixed tap and drag actions for Toggle --------- Co-authored-by: Anton Yarmolenko <[email protected]> * fix: gesture for ios 18.2 * chore: quick fix with performance for subtitles view --------- Co-authored-by: Saeed Bashir <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Shafqat Muneer <[email protected]>

* chore: add video and discussion analytics (#93) * fix: fixes after merge, deleted IAP parts * chore: changed dependency version, deleted unused analytics part * chore: regenerate mocks * chore: In app ratings modal and profile picture picture sheet UI improvements (#94) * chore: show subtitles for videos in full-screen mode (#97) * fix: after merge * fix: iOS 18 Toggle tap gesture (#98) * fix: added priority for toggle tap gesture * fix: fixed tap and drag actions for Toggle --------- Co-authored-by: Anton Yarmolenko <[email protected]> * fix: gesture for ios 18.2 * chore: quick fix with performance for subtitles view * chore: sign-in and register screens social sign in improvements (#95) * chore: fix after merge * fix: fix microsoft login issue on iOS after config branch merges (#96) * refactor: change the microsoft key name in the script (#101) * chore: fix access modifier * chore: re-generate nocks * chore: hide grades when sub section dependents not available (#99) * chore: fix after merge * chore: hide progress points from assignment status (#100) * chore: fix test --------- Co-authored-by: Saeed Bashir <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Shafqat Muneer <[email protected]>

fix: added priority for toggle tap gesture

a1946f7

rnr requested review from forgotvas and shafqat-muneer November 20, 2024 16:49

rnr changed the title ~~Fix: iOS 18 Toggle tap gesture~~ fix: iOS 18 Toggle tap gesture Nov 20, 2024

fix: fixed tap and drag actions for Toggle

19d44ac

forgotvas reviewed Nov 21, 2024

View reviewed changes

Course/Course/Presentation/Dates/CourseDatesView.swift

@@ -462,9 +462,16 @@ struct CalendarSyncView: View {

Toggle("", isOn: .constant(viewModel.isOn))

This comment was marked as resolved.

Sign in to view

forgotvas approved these changes Nov 21, 2024

View reviewed changes

shafqat-muneer approved these changes Nov 21, 2024

View reviewed changes

rnr merged commit 9409d67 into 2U/develop Nov 21, 2024
2 checks passed

rnr deleted the ios18-toggle-fix branch November 21, 2024 15:58

This was referenced Dec 17, 2024

chore: Notification preference settings and relevant code #104

Merged

fix: ios 18.2 Gesture Issue #108

Merged

rnr added a commit that referenced this pull request Dec 23, 2024

fix: iOS 18 Toggle tap gesture (#98)

7f8f347

* fix: added priority for toggle tap gesture * fix: fixed tap and drag actions for Toggle --------- Co-authored-by: Anton Yarmolenko <[email protected]>

rnr mentioned this pull request Dec 23, 2024

Sync: Part 10 sync to upstream openedx/openedx-app-ios#556

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: iOS 18 Toggle tap gesture #98

fix: iOS 18 Toggle tap gesture #98

rnr commented Nov 20, 2024 •

edited

Loading

shafqat-muneer commented Nov 20, 2024

rnr commented Nov 21, 2024

shafqat-muneer commented Nov 21, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

rnr commented Nov 21, 2024

shafqat-muneer left a comment

		@@ -135,13 +135,15 @@ struct CourseVideoDownloadBarView: View {
		Toggle("", isOn: .constant(viewModel.isOn))

		@@ -462,9 +462,16 @@ struct CalendarSyncView: View {
		Toggle("", isOn: .constant(viewModel.isOn))

fix: iOS 18 Toggle tap gesture #98

fix: iOS 18 Toggle tap gesture #98

Conversation

rnr commented Nov 20, 2024 • edited Loading

shafqat-muneer commented Nov 20, 2024

rnr commented Nov 21, 2024

shafqat-muneer commented Nov 21, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

rnr commented Nov 21, 2024

shafqat-muneer left a comment

Choose a reason for hiding this comment

rnr commented Nov 20, 2024 •

edited

Loading