-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sign-in and register screens social sign in improvements #95
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@saeedbashir @moiz994 Should Register screen says "Continue with"?
|
@rnr Yes, here is the axim/schema figma file for the feature; we actually follow their design. And here is the edX design file. |
This comment was marked as resolved.
This comment was marked as resolved.
Authorization/Authorization/Presentation/Registration/SignUpViewModel.swift
Outdated
Show resolved
Hide resolved
Authorization/Authorization/Presentation/Login/SignInViewModel.swift
Outdated
Show resolved
Hide resolved
Authorization/Authorization/Presentation/Registration/SignUpViewModel.swift
Outdated
Show resolved
Hide resolved
Authorization/Authorization/Presentation/SocialAuth/SocialAuthView.swift
Outdated
Show resolved
Hide resolved
Authorization/Authorization/Presentation/SocialAuth/SocialAuthView.swift
Show resolved
Hide resolved
Authorization/Authorization/Presentation/SocialAuth/SocialAuthViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
completion: { | ||
_ in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Can we use .svg files here to prevent blurriness on high-resolution screens, even though no issues have been observed so far?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using high-resolution images, so it's not needed.
Description
Jira Tickets:
LEARNER-10296
LEARNER-10297
Config:
https://github.com/edx/edx-mobile-config/pull/186
Screenshots
Note: I haven't implemented the more/less option for the social auth view. As at the moment, maximum 4 social auth options could be configured on mobile and more/less feature would be unused.
cc @moiz994