Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sign-in and register screens social sign in improvements #95

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

saeedbashir
Copy link

@saeedbashir saeedbashir commented Nov 18, 2024

Description

Jira Tickets:

LEARNER-10296
LEARNER-10297

Config:

https://github.com/edx/edx-mobile-config/pull/186

Screenshots

Axim Light Axim Dark edX Light edx Dark
axim_sign_in_light axim_sign_in edx_sign_in-light edx_sign_in
axim_last_sign_in_light axim_last_sign_in edx_last_sign edxa_last_sign_in
axim_register_light axim_register edx_register_dark edx_register

Note: I haven't implemented the more/less option for the social auth view. As at the moment, maximum 4 social auth options could be configured on mobile and more/less feature would be unused.
cc @moiz994

@rnr

This comment was marked as resolved.

@rnr

This comment was marked as resolved.

@rnr
Copy link
Collaborator

rnr commented Nov 18, 2024

@saeedbashir @moiz994 Should Register screen says "Continue with"?

Before After
Screenshot 2024-11-18 at 14 54 26 Screenshot 2024-11-18 at 14 54 50

@saeedbashir
Copy link
Author

Hello @saeedbashir Are these design changes approved by Axim? @marcotuts @sdaitzman Thank you

@rnr Yes, here is the axim/schema figma file for the feature; we actually follow their design. And here is the edX design file.

@rnr

This comment was marked as resolved.

Copy link
Collaborator

@rnr rnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@shafqat-muneer
Copy link

After adding the last social sign-in option, the screen's left and right margins became misaligned and need to be fixed.

Before Last Social Sign-in Option After Last Social Sign-in Option
Simulator Screenshot - iPhone 16 - 2024-11-20 at 21 59 54 Simulator Screenshot - iPhone 16 - 2024-11-20 at 21 57 23

Comment on lines 149 to 150
completion: {
_ in

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Can we use .svg files here to prevent blurriness on high-resolution screens, even though no issues have been observed so far?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using high-resolution images, so it's not needed.

@shafqat-muneer
Copy link

LGTM 👍

After Last Social Sign-in Option

@saeedbashir saeedbashir merged commit 264fb81 into 2U/develop Nov 25, 2024
2 checks passed
@saeedbashir saeedbashir deleted the saeed/LEARNER-10296 branch November 25, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants