Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Theme Improvements for Primary Course Card #37

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

HamzaIsrar12
Copy link

Description

Improve Primary Course Card CTAs Background Color (left is for light & right is for dark):

Screenshot 2024-08-19 at 4 24 07 PM

Attachments

Before After Before After

Fixes: LEARNER-10078

@HamzaIsrar12 HamzaIsrar12 merged commit 7906f84 into 2U/develop Aug 21, 2024
4 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-10078 branch August 21, 2024 11:47
@sdaitzman
Copy link

I don't think this should be upstreamed as-is. I'm unclear on the benefit of adding additional colors to the quick actions, is there some reason to make hierarchy obvious for course options beyond primary quick action / secondary quick actions?

@moiz994
Copy link

moiz994 commented Nov 15, 2024

hey Sam, the main goal of adding additional colors to the quick actions is to provide a more intuitive and visually distinct hierarchy for course options. By differentiating the primary quick actions from the secondary ones, we aim to improve usability and guide users more effectively to the most critical actions.

This distinction can be particularly helpful in scenarios where users need to quickly prioritize their actions or where secondary options might otherwise blend in and go unnoticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants