From 70c0df66f196aa3c9ac1c01f166afe032512b1f3 Mon Sep 17 00:00:00 2001 From: Hamza442 Date: Fri, 12 Aug 2022 16:00:17 +0500 Subject: [PATCH] fix: Updated dbt-core and dbt-snowflake version to resolve dependencies conflict --- dbt_schema_builder/__init__.py | 2 +- requirements/base.in | 4 ++-- requirements/constraints.txt | 17 ++++++++++++++++- 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/dbt_schema_builder/__init__.py b/dbt_schema_builder/__init__.py index f5e96b2..134dcfa 100644 --- a/dbt_schema_builder/__init__.py +++ b/dbt_schema_builder/__init__.py @@ -2,4 +2,4 @@ Automate management of PII redacted schemas for dbt projects. """ -__version__ = '0.4.4' +__version__ = '0.4.5' diff --git a/requirements/base.in b/requirements/base.in index a7d9951..9f580df 100644 --- a/requirements/base.in +++ b/requirements/base.in @@ -1,5 +1,5 @@ # Core requirements for using this application -c constraints.txt -dbt-core==1.0.3 -dbt-snowflake==1.0.0 +dbt-core==1.2.0 +dbt-snowflake==1.2.0 diff --git a/requirements/constraints.txt b/requirements/constraints.txt index 6afcc96..e532e02 100644 --- a/requirements/constraints.txt +++ b/requirements/constraints.txt @@ -12,4 +12,19 @@ packaging==20.9 # Pinning snowflake-connector-python due to following issue # https://github.com/snowflakedb/snowflake-connector-python/issues/1206 -snowflake-connector-python==2.7.9 \ No newline at end of file +snowflake-connector-python==2.7.9 + +# Pinning below mentioned dependencies because when we do make upgrade there is conflict between dependencies +# snowflake-connector-python 2.7.9 install werkzeug 2.2.2 in which MarkupSafe is pinned to MarkupSafe>=2.1.1 +# https://github.com/pallets/werkzeug/blob/2.2.2/setup.py +# This cause error: Could not find a version that matches MarkupSafe==2.0.1,==2.1.1 (from -c requirements/constraints.txt (line 17)) +# Because in dbt-score 1.0.3 MarkupSafe is pinned to 2.0.1 and in dbt-score 1.2.0 MarkupSafe is pinned to MarkupSafe>=0.23,<2.1 +# https://github.com/dbt-labs/dbt-core/blob/v1.2.0/core/setup.py#L52 +# https://github.com/dbt-labs/dbt-core/blob/v1.0.3/core/setup.py#L55 +# Due to this reason we are pinnig to werkzeug==2.1.2, becuase in this version MarkupSafe is not pinned +# https://github.com/pallets/werkzeug/blob/2.1.2/setup.py +# Also with this change dbt-core and dbt-snowflake version was dumped to 1.2.0 in base.in file +# becuase dbt-snowflake==1.0.0 has hard limit cryptography<4,>=3.2 and snowflake-connector-python==2.7.9 has hard limit cryptography<37.0.0,>=3.1.0. +# This was causing conflict so needed to upgrade dbt-snowflake and dbt-core to 1.2.0 +werkzeug==2.1.2 +charset-normalizer==2.0.12