-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intra-page links should not open in a new tab/window #494
Labels
Comments
Update: this also applies to |
I'll take this @Mr0grog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #405 we made links open in new browser tabs/windows rather than navigating the diff view. That was a good improvement, but it also happens when clicking intra-page links, like the “Proposed Changes - A Holistic Approach to Closure Part B” link here:
https://monitoring.envirodatagov.org/page/c7a491b7-b296-4bdf-965e-372a87a7ac05/6f12e08a-a7f7-4ed1-8775-8c3791614fba..1fdefab4-bf6e-4829-892a-32c35466ae3d
That link should really just scroll down the page.
To fix this, we probably just need to check whether the
href
starts with#
before addingtarget="_blank"
to a link here:web-monitoring-ui/src/scripts/html-transforms.js
Lines 51 to 68 in 3ed21c2
The text was updated successfully, but these errors were encountered: