Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more graceful when Google sheets is not configured #212

Open
Mr0grog opened this issue Mar 12, 2018 · 5 comments
Open

Be more graceful when Google sheets is not configured #212

Mr0grog opened this issue Mar 12, 2018 · 5 comments

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Mar 12, 2018

Enough people have hit confusion around the Google sheets configuration that we really should clean this up. The current status is that it’s “optional” in the sense that certain routes are expected not to work and the app won’t crash if not configured. But we log config errors in that case and people get confused. So:

  • Methods that retrieve data from sheets should return early with nice errors if not configured (server/sheet-data.js)

  • The UI should not have an “assigned pages” view or support the assigned pages routes when sheets is not configured. This should probably be a config var named something like SHOW_ASSIGNED_PAGES for the front-end that is calculated based on the Google Sheets env vars. (server/configuration.js)

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2019
@Mr0grog
Copy link
Member Author

Mr0grog commented Jan 10, 2019

This has been a barrier for some contributors, so I think it’s important to track and fix.

@stale stale bot removed the stale label Jan 10, 2019
@stale
Copy link

stale bot commented Jul 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jul 9, 2019
@stale stale bot removed the stale label Jul 9, 2019
@lightandluck
Copy link
Collaborator

Added never-stale label

@Mr0grog
Copy link
Member Author

Mr0grog commented Feb 3, 2020

The sheets-related methods still need to return early if not configured, but we removed the assigned pages view and all the associated bits (the most painful part people were running into) in #395 and #398.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants