Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: System accent theme doesn't match chrome colors #81

Open
cantunborn opened this issue Oct 23, 2024 · 5 comments
Open

[Bug]: System accent theme doesn't match chrome colors #81

cantunborn opened this issue Oct 23, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@cantunborn
Copy link

What happened?

After changing the theme from default dark to the system accent colors (which is picked from the windows accent color), the tab and toolbar don't have the same colors as chrome does on Windows 11. Chrome has more darkish and contrasty colors but material fox has more muted greyish colors.

Colors in chrome:
Screenshot 2024-10-22 224639

Colors in material fox:
Screenshot 2024-10-22 224700

Steps to reproduce

  1. Download the system accent theme CSS file from here to the chrome/ folder in Firefox profile folder.
  2. Set userChrome.theme-system-accent is about:config as true.
  3. Open Firefox.

Additional info (Optional)

Firefox version: 131.0.3
Operating system: Windows 11

@cantunborn cantunborn added the bug Something isn't working label Oct 23, 2024
@edelvarden
Copy link
Owner

I can't reproduce your issue. Here's how it looks for me:

image

I simply added the contents of the theme-system-accent.css file to the custom css and set userChrome.theme-system-accent to true.

Anyway, this is just an example. I made this color theme for myself and wanted to remove it, but one user insisted I keep it and suggested separating it into different theme file. Feel free to edit the variables as you like.

@cantunborn
Copy link
Author

Yeah, I could edit the variables. This would be a nice feature to add though, making the theme more consistent. Maybe you can check on the default windows 11 wallpaper, the difference is quite large.

Any tips on how you went about matching the colors would also work.

@edelvarden
Copy link
Owner

Maybe you can check on the default windows 11 wallpaper, the difference is quite large.

image
image
image
image

Any tips on how you went about matching the colors would also work.

I used color-mix to mix the default browser colors with the accent color, adjusting the percentages to achieve an acceptable shade. I also toned down the accent color by mixing with white/black, as some colors can be too bright, this is just for compatibility, but you can directly use AccentColor, which provides access to the system accent color from CSS.

@cantunborn
Copy link
Author

I noticed something, if you right click the tab bar on firefox and then enable the title bar in the bottom left, you can see that chrome somehow uses that same color in its tab bar.

Is it possible to access this title bar color in firefox userchrome?

@cantunborn
Copy link
Author

I just found the color value in this registry location: HKEY_CURRENT_USER\Software\Microsoft\Windows\DWM\ColorizationColor, not sure if it can be accessed inside userChrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants