新增Action中leave方法里调用Action.prototype.dispose #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -284,6 +284,15 @@ define( | |||
| } | |||
|
|
|||
| /** | |||
| * 如果Action本身也有dispose方法，则执行 | |||
| * 主要用来dispose掉一些DOM事就绑定，因为我们经常在Action中通过bindEvent来绑定DOM事件 | |||
There was a problem hiding this comment.
同意楼上，这个调用dispose的逻辑本身没问题，注释最好改改，太误导人
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.