Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct link to workspace does not work when missing trailing / #23

Open
jfaltermeier opened this issue Apr 22, 2022 · 11 comments
Open

Direct link to workspace does not work when missing trailing / #23

jfaltermeier opened this issue Apr 22, 2022 · 11 comments
Labels
bug Something isn't working prio-medium

Comments

@jfaltermeier
Copy link
Contributor

jfaltermeier commented Apr 22, 2022

Landing pages may also need the trailing / to function properly.
Probably there is a way to configure the nginx ingress to make this work without /

@jfaltermeier jfaltermeier added the bug Something isn't working label Apr 22, 2022
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale label Nov 13, 2022
@jfaltermeier

This comment was marked as outdated.

@github-actions github-actions bot removed the stale label Nov 14, 2022
@lucas-koehler lucas-koehler self-assigned this Dec 12, 2022
lucas-koehler added a commit that referenced this issue Dec 12, 2022
Add an NginX snippet to the instances ingress:
When the URL does not request a file and does not end with a `/`,
redirect to add a trailing `/`.
This allows correct resolution of relative paths to resources (e.g. js, css files).

Fix #23

Contributed on behalf of STMicroelectronics and CEA

Signed-off-by: Lucas Koehler <[email protected]>
lucas-koehler added a commit to eclipse-theia/theia-cloud-helm that referenced this issue Dec 12, 2022
Add an NginX snippet to the instances ingress:
When the URL does not request a file and does not end with a `/`,
redirect to add a trailing `/`.
This allows correct resolution of relative paths to resources (e.g. js, css files).

Related to eclipse-theia/theia-cloud#23

Contributed on behalf of STMicroelectronics and CEA

Signed-off-by: Lucas Koehler <[email protected]>
lucas-koehler added a commit that referenced this issue Dec 13, 2022
Add an NginX snippet to the instances ingress:
When the URL does not request a file and does not end with a `/`,
redirect to add a trailing `/`.
This allows correct resolution of relative paths to resources (e.g. js, css files).

TODO: works without keycloak; ends in redirect loop with keycloak

WillFix #23

Contributed on behalf of STMicroelectronics and CEA

Signed-off-by: Lucas Koehler <[email protected]>
lucas-koehler added a commit to eclipse-theia/theia-cloud-helm that referenced this issue Dec 13, 2022
Add an NginX snippet to the instances ingress:
When the URL does not request a file and does not end with a `/`,
redirect to add a trailing `/`.
This allows correct resolution of relative paths to resources (e.g. js, css files).

TODO: works without keycloak; ends in redirect loop with keycloak

Related to eclipse-theia/theia-cloud#23

Contributed on behalf of STMicroelectronics and CEA

Signed-off-by: Lucas Koehler <[email protected]>
@lucas-koehler
Copy link
Contributor

Does not work the same as the redirect for landing pages because it results in a redirect loop when using keycloak

@lucas-koehler lucas-koehler removed their assignment Dec 13, 2022
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale label Mar 14, 2023
@jfaltermeier

This comment was marked as outdated.

@github-actions github-actions bot removed the stale label Mar 18, 2023
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale label Jun 17, 2023
@lucas-koehler

This comment was marked as outdated.

@github-actions github-actions bot removed the stale label Jun 19, 2023
Copy link

This issue is stale because it has been open for 180 days with no activity.

@github-actions github-actions bot added the stale label Dec 17, 2023
@jfaltermeier
Copy link
Contributor Author

Keep open

@github-actions github-actions bot removed the stale label Dec 18, 2023
Copy link

This issue is stale because it has been open for 180 days with no activity.

@github-actions github-actions bot added the stale label Jun 16, 2024
Copy link

github-actions bot commented Jul 1, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
@jfaltermeier jfaltermeier reopened this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio-medium
Projects
None yet
Development

No branches or pull requests

2 participants