File search incorrectly reports shown matches (shown file count vs shown match count)

[bremk42-sys]

Let's make sure issue is not already fixed in latest builds first.

• I looked at the source code of the master branch (FileSearchPage.java) and the code seams to be identical to the code in my Eclipse 4.35 installation.

Steps to reproduce

Create a text file with the following 3 lines:
ABC
ABCBC
ABCDCDC

Then do a file search on the file and search for "A". The label of the search view says "3 matches in ..." OK
Then repeat the search and search for "B". The label of the search view says "4 matches in ... (showing 3 of 4 matches)" which is NOT OK because all matches are shown.
If you search for "C" the label will be "6 matches in ... (showing 3 of 6 matches)" which is also NOT OK.

Since all matches are shown in the search view the view should not report not shown matches.

Locking at the source code of the label generation in FileSearchPage.getLabel() the problem seams to be an incorrect comparison of lines (leaves in the tree) and matches in the first if branch that generates this label extension.

Tested under this environment:

• OS & version: Windows 11
• Eclipse IDE/Platform version (as shown in Help > About): 4.35

Community

• I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

[iloveeclipse]

Still on master:

Are you sure it is a recent regression? The code in question was last touched 2 years ago, see 0474b01

[bremk42-sys]

Wow, quick response. I will check that in the latest version I get. But if this screenshot is from the master, it shows the problem. "showing 3 of 4 matches" should not be added to the label because all 4 matches are shown.

[iloveeclipse]

if this screenshot is from the master

It is, otherwise I wouldn't write that.

[bremk42-sys]

Okay, thanks. Then I am sure that this should be fixed.

[iloveeclipse]

Then I am sure that this should be fixed.

Contributions are welcome. See https://github.com/eclipse-platform/eclipse.platform.ui?tab=contributing-ov-file

[fedejeanne]

Are you sure it is a recent regression?

Nope...

[bremk42-sys]

Nope? So please help me to understand the label extension "showing 3 of 4 matches".
Since no match is filtered out because of a filter or a limit, it should say "showing 4 of 4 matches" or just nothing.
For me it looks like the current meaning is somewhat like "showing 3 lines with 4 matches" but this information is just confusing.

[tomaswolf]

"Nope" meant "it's not a regression; it was like that already in Eclipse 2024-12 (and possibly older versions)".

Evidently the label mixes up number of lines vs. number of matches. Whenever a line has multiple matches, the label will be wrong.

[fedejeanne]

Nope? So please help me to understand ...

@bremk42-sys I meant it's not recent.

But it's definitely a bug, it needs to be fixed :-)