This repository was archived by the owner on Aug 11, 2025. It is now read-only.
Remove parent pom dependency #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Overall looks good. Only complain is that brings '[WARNING] Using platform encoding (UTF-8 actually) to read mojo source files, i.e. build is platform dependent!' , please add |
laeubi
force-pushed
the
remove_pp
branch
2 times, most recently
from
ae897a9 to
8b19966
Compare
Contributor
Author
|
Done! |
laeubi
force-pushed
the
remove_pp
branch
2 times, most recently
from
bc7641d to
03b0a2d
Compare
Contributor
Author
|
Also added some more cleanups to the Jenkinsfile |
akurtakov
approved these changes
May 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akurtakov WDYT? The build here does not really make any use of the parent pom (we only call plain maven mojos here) and it seems to have less dependencies is better. Actually this could even have an own versioning as we never deploy it anywhere (see #81 ) would also fix #137 as there is no need for eclipse infra to host a unused parent.