-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Xtrace String printing feature #20878
Labels
Comments
@h3110n3rv3 Please address the concersn regarding Strings being used as a receiver for method calls (It would be great to see String contents for this references as well). |
We can look at |
h3110n3rv3
added a commit
to h3110n3rv3/openj9
that referenced
this issue
Jan 17, 2025
The changes reflect the feature request eclipse-openj9#20878. Print string contents for this references. Also, print address for string arguments and returns. Closes: eclipse-openj9#20878 Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3
added a commit
to h3110n3rv3/openj9
that referenced
this issue
Jan 23, 2025
The changes reflect the feature request eclipse-openj9#20878. Print string contents for this references. Also, print address for string arguments and returns. Closes: eclipse-openj9#20878 Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3
added a commit
to h3110n3rv3/openj9
that referenced
this issue
Jan 23, 2025
The changes reflect the feature request eclipse-openj9#20878. Print string contents for this references. Also, print address for string arguments and returns. Closes: eclipse-openj9#20878 Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3
added a commit
to h3110n3rv3/openj9
that referenced
this issue
Jan 23, 2025
The changes reflect the feature request eclipse-openj9#20878. Print string contents for this references. Also, print address for string arguments and returns. Closes: eclipse-openj9#20878 Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3
added a commit
to h3110n3rv3/openj9
that referenced
this issue
Jan 24, 2025
The changes reflect the feature request eclipse-openj9#20878. Print string contents for this references. Also, print address for string arguments and returns. Closes: eclipse-openj9#20878 Signed-off-by: Nick Kamal <[email protected]>
h3110n3rv3
added a commit
to h3110n3rv3/openj9
that referenced
this issue
Jan 24, 2025
The changes reflect the feature request eclipse-openj9#20878. Print string contents for this references. Also, print address for string arguments and returns. Closes: eclipse-openj9#20878 Signed-off-by: Nick Kamal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Suggested improvements for the new Xtrace String printing feature introduced for #16416:
First,
this
references for String objects are still shown only as addresses. For example on the first and second lines here:It would be great to see String contents for
this
references as well.Second, the Strings' contents are now printed instead of their addresses, but there are situations where having both would be useful - for example, if you wanted to locate the String objects in a dump that was taken alongside the trace.
Finally, would it be possible to print the contents of
char[]
instances (and maybe evenbyte[]
) in the same way? A text representation of abyte[]
(e.g. interpreting each byte as an ASCII codepoint) wouldn't always be useful, but there are definitely times when it would be.The text was updated successfully, but these errors were encountered: