Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow '[' and ']' to be used for specifying options in subset #7257

Open
mpirvu opened this issue Feb 8, 2024 · 0 comments
Open

Allow '[' and ']' to be used for specifying options in subset #7257

mpirvu opened this issue Feb 8, 2024 · 0 comments

Comments

@mpirvu
Copy link
Contributor

mpirvu commented Feb 8, 2024

To specify options in a subset (that apply only to some methods) you use the following format:
-Xjit:{methodRegex}(options_in_subset)
On Linux this runs into the following error caused by the shell:

-bash: syntax error near unexpected token `('

Possible workarounds are:

  • Surround JIT command line options with single or double quotes
  • Escape the brackets: \( \)

However, when testing uses multiple levels of perl/python/shell scripts it becomes difficult to reason about what workarounds work.
This issue proposes the usage of square brackets for specifying options_in_subset, in addition to the round brackets. Thus, both
-Xjit:{methodRegex}(options_in_subset)
and
-Xjit:{methodRegex}[options_in_subset]
should be valid.

mpirvu added a commit to mpirvu/omr that referenced this issue Feb 8, 2024
This commit allows the user to specify options in a subset using
square brackets as opposed to normal brackets which is the norm.
E.g.:  -Xjit:{methodRegex}[options-to-use]

Normal (round) brackets will continue to work as before.

Issue: eclipse-omr#7257

Signed-off-by: Marius Pirvu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants