copilot review comments

Signed-off-by: Jonah Iden <[email protected]>

Author: jonah-iden

packages/open-collaboration-service-process/Readme.md

@@ -23,9 +23,9 @@ node ./lib/process.js --server-address http://localhost:8100 --auth-token <your-
 ### Communication Protocol
 
 All communication happens via JSON-RPC 2.0 messages over stdin/stdout.
-See [messages.ts](src/messages.ts) for service process specific awarness or lifecycle messages. Other messages follow the open-collaboration-protocol.
+See [messages.ts](src/messages.ts) for service process specific awareness or lifecycle messages. Other messages follow the open-collaboration-protocol.
 
-For specific examples see `service.process.test.ts` or the [IntellIj integration](https://github.com/eclipse-oct/oct-intellij)
+For specific examples see `service.process.test.ts` or the [IntellIJ integration](https://github.com/eclipse-oct/oct-intellij)
 
 ### Sending and Receiving Binary Data
 

packages/open-collaboration-service-process/src/message-handler.ts

@@ -65,7 +65,7 @@ export class MessageHandler {
                     return fromBinaryMessage(param.data);
                 }
                 return param;
-            });;
+            });
 
             if(metaDataParam === 'broadcast') {
                 this.currentCollaborationInstance?.octConnection.sendBroadcast(method, ...messageParams);

packages/open-collaboration-service-process/src/messages.ts

@@ -150,7 +150,7 @@ export namespace BinaryData {
     }
 
     export function shouldConvert(message: unknown): boolean {
-        if (typeof message !== 'object' && message !== null) {
+        if (typeof message !== 'object' || message === null) {
             return false;
         }
 
@@ -162,7 +162,7 @@ export namespace BinaryData {
             return message.some((item) => shouldConvert(item));
         }
 
-        return Object.keys(message!).some((key) => shouldConvert((message as Record<string, unknown>)[key]));
+        return Object.keys(message).some((key) => shouldConvert((message as Record<string, unknown>)[key]));
     }
 }