@msujew please let me know when we have an alpha for this. would like to test.

@cdietrich I got around to publish 3.4.0-next.1409e5d which contains this change.

thx will give it a test

hmmm its not working. need to debug ....

for some reason the notebook documents dont end up in text documents

we do this in our service registry
const textDocument = this.sharedServices.workspace.TextDocuments.get(uri.toString())

but

this.sharedServices.workspace.TextDocuments.all()

is empty

@cdietrich Thanks for looking into it. I'll take another look to see what's wrong. I probably missed something when adapting the Microsoft implementation.

Then I ask for cell and document by cell I get one step more
But then services crash with document already present

need to figure out why

Maybe there is still to much double escaping somewhere

hmmm no. when i use

  let languageId: string | undefined = undefined
      const cell = this.sharedServices.workspace.NotebookDocuments.getNotebookCell(uri.toString())
      if (cell !== undefined) {
        languageId = this.sharedServices.workspace.NotebookDocuments.getCellTextDocument(cell)?.languageId
      } else {
        console.log("nooooo ceeeellll")
      }

in the service registry the cell map is still empty in the early stage (guard in fireDocumentUpdate)

hmmm somehow not all docs end up in
_syncedDocuments

this is cause vscode sends only 4 of 9 cells. need to digg why

update: found the reason for it. now if still end up with failing services / no registered service found.
need to check ..

upon further debugging
the this.sharedServices.workspace.TextDocuments
indeed does not get populated upon open

looks like i somehow end up with multiple NormalizedTextDocs. need to figure out why.

hmmmm
NotebookDocuments: () => new NormalizedNotebookDocuments(TextDocument)

should this be

NotebookDocuments: (services) => new NormalizedNotebookDocuments(services.workspace.TextDocuments)

looks better now. we will do some thorough testing tomorrow

All tests from our side look good