-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define pid_t for different platforms and use it for filedescriptors #480
Comments
@dkroenke I would recommend to introduce |
@elfenpiff I'm not sure about the naming convention. I understand that for the semaphore we add the "iox_" prefix because we made a custom implementation for it on the different platforms. |
@dkroenke I hope you are right but sometimes Windows suprises you and then we have another iox_ prefix ... But for now you are right, we should not over complicate things! |
Closing in favor of #2289 which shall add the prefix to all entities in the platform abstraction |
Brief feature description
In iceoryx we are creating and using often filedescriptors. In POSIX standard the type for descriptors is defined as
pid_t
in <sys/types.h> on Unix.In iceoryx we have
iceoryx_utils/platform/types.hpp
for the diferent platforms as header available. This should be consistently used instead of int for all filedescriptors in iceoryx.Please be aware that windows doesn't know
pid_t
, it make sense to add a define for having it as int.The text was updated successfully, but these errors were encountered: