Is the logging lib supposed to be stack based? #1040
-
Looking at the source code of the logging module, I discover that it uses the heap. For example the struct LogEntry
{
LogLevel level{LogLevel::kVerbose};
std::chrono::milliseconds time{0};
std::string message; // <------- heap
}; Isn't it against the rules written in the CONTRIBUTION.md?
|
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
@aadeg this was just a stop gap solution. I'm currently working on a design document to overhaul the logger and also remove the heap usage. There are a few other places where currently a |
Beta Was this translation helpful? Give feedback.
-
Great news! Thanks for the clarification |
Beta Was this translation helpful? Give feedback.
@aadeg this was just a stop gap solution. I'm currently working on a design document to overhaul the logger and also remove the heap usage. There are a few other places where currently a
std::string
is used. All of this will be fixed in the future.