Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto approve action incorrectly marking files as public API. #1507

Open
KerstinKeller opened this issue Apr 4, 2024 · 1 comment
Open

Auto approve action incorrectly marking files as public API. #1507

KerstinKeller opened this issue Apr 4, 2024 · 1 comment

Comments

@KerstinKeller
Copy link
Contributor

Problem Description

I changed some files in "contrib/mma/include/windows/network.h" which is not public eCAL API, yet the auto approve action refused to approve because it claims that it was.

Run echo "ERROR: Protected files have been changed:"
ERROR: Protected files have been changed:
contrib/mma/include/windows/network.h
Error: Process completed with exit code 1.

How to reproduce

How did you get eCAL?

I don't know

Environment

eCAL System Information

No response

@FlorianReimold
Copy link
Member

Here are the files that cannot be auto-approved:

files: |
app/app_pb/**
contrib/**/include/**
contrib/ecaltime/ecaltime_pb/**
ecal/core/cfg/**
ecal/core/include/**
ecal/core_pb/**
ecal/pb/**
lang/**
thirdparty/**
.gitmodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants