Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Windows installer does not include ecal_core.dll #2

Open
KerstinKeller opened this issue Mar 29, 2023 · 3 comments
Open

The Windows installer does not include ecal_core.dll #2

KerstinKeller opened this issue Mar 29, 2023 · 3 comments

Comments

@KerstinKeller
Copy link
Contributor

Ideally, the installers (Windows) should work standalone and thus contain ecal_core.dll

@FlorianReimold
Copy link
Member

FlorianReimold commented Mar 31, 2023

Hm, so this is a .zip file, that is supposed to be extracted to the eCAL directory. If it would include the ecal_core.dll, it would overwrite it with a different version. I don't think that would be beneficial.

If this were supposed to run standalone, it would also have to ship the ecal.ini and an entire eCAL Monitor along with the monitor plugin. In my mind, this doesn't sound like a great idea.

The Readme.md has a section that explains how to "install" the prebuilt binaries from the zip file: https://github.com/eclipse-ecal/ecal-camera-samples#how-to-install-prebuilt-binaries

@KerstinKeller
Copy link
Contributor Author

Mhmh, this might make sense for the monitor plugin. I just wanted to quickly test / use the camera grabber (no plugin), which then doesn't work by itself.

Maybe we split into two different installers (standalone grabber, monitor_plugin) and package accordingly?

@FlorianReimold
Copy link
Member

Sure, that would be possible. With the official open source installer however, the ecal_core.dll usually is in the PATH, so the quick test should work perfectly. This may not be true for for custom builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants