From 2a4b5b690b39a27357f1ce228a65a897b5829578 Mon Sep 17 00:00:00 2001
From: Evan Shimizu
Date: Sun, 25 Feb 2018 11:24:47 -0500
Subject: [PATCH] hotfix: braxis wave not spawning crashes match details
---
js/match-detail.js | 74 ++++++++++++++++++++-------------------
package.json | 2 +-
templates/about-page.html | 2 ++
3 files changed, 41 insertions(+), 37 deletions(-)
diff --git a/js/match-detail.js b/js/match-detail.js
index 7420223..3e9d52c 100644
--- a/js/match-detail.js
+++ b/js/match-detail.js
@@ -1066,42 +1066,44 @@ function getBraxisEvents(items) {
let item0 = {};
let item1 = {};
- item0.start = wave.startTime;
- item1.start = wave.startTime;
- item0.end = wave.endTime[0];
- item1.end = wave.endTime[1];
-
- item0.className = 'blue';
- item1.className = 'red';
-
- let t0 = (wave.startScore[0] * 100).toFixed(2) + '% Zerg Wave';
- let t1 = (wave.startScore[1] * 100).toFixed(2) + '% Zerg Wave';
-
- let pop0 = "";
-
- let pop1 = "";
-
- item0.content = '';
- item1.content = '';
-
- item0.group = 54
- item1.group = 5;
-
- items.push(item0);
- items.push(item1);
-
- // spawns
- sitem = {};
- sitem.start = wave.initTime;
- sitem.content = "Beacons Active";
- sitem.type = 'background';
- sitem.group = 5;
- sitem.end = wave.startTime;
- items.push(sitem);
+ if ('startTime' in wave) {
+ item0.start = wave.startTime;
+ item1.start = wave.startTime;
+ item0.end = wave.endTime[0];
+ item1.end = wave.endTime[1];
+
+ item0.className = 'blue';
+ item1.className = 'red';
+
+ let t0 = (wave.startScore[0] * 100).toFixed(2) + '% Zerg Wave';
+ let t1 = (wave.startScore[1] * 100).toFixed(2) + '% Zerg Wave';
+
+ let pop0 = "";
+
+ let pop1 = "";
+
+ item0.content = '';
+ item1.content = '';
+
+ item0.group = 54
+ item1.group = 5;
+
+ items.push(item0);
+ items.push(item1);
+
+ // spawns
+ sitem = {};
+ sitem.start = wave.initTime;
+ sitem.content = "Beacons Active";
+ sitem.type = 'background';
+ sitem.group = 5;
+ sitem.end = wave.startTime;
+ items.push(sitem);
+ }
}
}
diff --git a/package.json b/package.json
index f705b0b..c8d1a73 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "stats-of-the-storm",
- "version": "0.3.0-dev",
+ "version": "0.2.2",
"main": "main.js",
"description": "A Heroes of the Storm stat tracking application.",
"bugs": "falindrith@gmail.com",
diff --git a/templates/about-page.html b/templates/about-page.html
index 6283a99..6e057c8 100644
--- a/templates/about-page.html
+++ b/templates/about-page.html
@@ -16,6 +16,8 @@
Change Log
+
+ Match Details: Corrected an issue for Braxis Holdout, where beacons would spawn but the game would end before a wave would spawn, causing a crash in the timeline view
Draft Stats: hotfix for pre-2.0 (client version 2.25.0) replays missing draft pick and ban data.
Correctly applied player game threshold to Player Details with/against player tables.