Test for an archive with empty files

[eagleflo]

This was broken under Python 3 for a long time.

[GraylinKim]

Do you need me to provide one of these? The archives I originally found the issue with are private but I can dig around and find one for this.

[eagleflo]

Sure, I'd appreciate if you could find a reasonably small archive with at least one empty file.

For legal reasons it has to be user-generated, though, and preferably with official tools such as game clients or map editors.

[eagleflo]

We could of course also create an artificial test-case archive if we can be sure that it matches what is found in the wild.

[MGatner]

Wow this has been open a long time. I ran into this issue try to extract_to_disk (from CLI, -x) from a Heroes or the Storm .StormReplay file. Actually all of these archives I've tested so far have a zero-byte file in them; I am glad to provide one or many as examples.
My fix has been to add a test for empty data before calling fwrite; I'll see if I can implement an example in this repo. I'm not sure where else the empty file(s) are an issue though.

[MGatner]

Ah actually it looks like this is fixed in the current version here! https://github.com/Blizzard/heroprotocol appears to have an old version of mpyq included which is causing the issue.
@eagleflo were there other issues with empty files other than writing to disk? I haven't run into them so far...

[eagleflo]

No, I think #28 fixed that.

[MGatner]

Awesome. I’m pulling in your latest and dropping the one heroprotocol has included. Probably safe to close #30 if that’s the case. Matt Gatner [email protected]

…

On Apr 28, 2018, at 4:18 PM, Aku Kotkavuo ***@***.***> wrote: No, I think #28 <#28> fixed that. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQwj7zwznx4hABd3KaiXBShxtbEkJgFqks5ttM6JgaJpZM4BqG15>.