Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with rule refinement: Static analysis #369

Open
anthonyanjorin opened this issue Sep 5, 2018 · 5 comments
Open

Bug with rule refinement: Static analysis #369

anthonyanjorin opened this issue Sep 5, 2018 · 5 comments
Assignees
Labels

Comments

@anthonyanjorin
Copy link
Contributor

Refinement does not seem to work correctly for overriding correspondence types.

Subtypes should win, but we should also complain if there is no clear "lowest" subtype. Currently we just pick one of the types without any warning or error.

@anthonyanjorin anthonyanjorin self-assigned this Sep 5, 2018
@09Ankita 09Ankita assigned saman and filipgia and unassigned 09Ankita Nov 12, 2018
@anthonyanjorin
Copy link
Contributor Author

Any progress? Have you been able to reproduce?

@filipgia
Copy link
Contributor

Hello,
@saman and I had two meetings with @NilsWeidmann . We are investigating on this issue. Right now, we have three breakpoints. We are trying to find the way to make a sup-type win and log it with the Logger.

@anthonyanjorin
Copy link
Contributor Author

ok - so first concentrate on simply reproducing right? That means I believe a clear subtype must win at the moment. The problem is more when there is no clear lowest subtype. This is a specification error and must be flagged as such. Instead at the moment something just happens.

E.g.:

CorrA ...
CorrB extends CorrA
CorrC extends CorrA

If you then have a rule X with CorrB, a rule Y with CorrC, and a rule Z that refines X and Y you should get an error as it is unclear if Z should use CorrB and CorrC (they are not comparable).

Clear?

@filipgia
Copy link
Contributor

filipgia commented Nov 27, 2018

Yes it is clear. At the moment we are using
FeatureModelConciseToSafe. But we will also try your example.

@anthonyanjorin
Copy link
Contributor Author

That’s fine. Any example is ok if you can reproduce the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants