Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit out if nvidia-smi is not present in PATH for production mode. #26

Open
deepujain opened this issue Sep 4, 2019 · 0 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@deepujain
Copy link
Contributor

  1. nvidiagpubeat can be run in production mode.
  2. In case nvidia-smi is not in PATH, then throw appropriate error message and exit

Possible solution

  1. gpu.go command() must return err object for above scenario.
    2.metrics.go must check on error and work accordingly.
if err != nil return err ```

Ex

2019-09-04T12:32:57.008-0700 INFO instance/beat.go:400 nvidiagpubeat start running.
2019-09-04T12:32:57.008-0700 INFO beater/nvidiagpubeat.go:57 nvidiagpubeat is running for ** production ** environment. ! Hit CTRL-C to stop it.
2019-09-04T12:32:58.038-0700 ERROR nvidia/gpu.go:52 E! nvidia-smi is not in PATH. Exit !!!

@deepujain deepujain added enhancement New feature or request help wanted Extra attention is needed labels Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant