Skip to content

Commit 5f3f0f3

Browse files
committed
AUT-2042 Send post-logout-redirect-uri as query parameter when logging out
1 parent df3f343 commit 5f3f0f3

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

src/main/java/ee/ria/govsso/client/controller/ClientController.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ public class ClientController {
4646
private String applicationIntroLong;
4747
@Value("${example-client.messages.info-service}")
4848
private String applicationInfoService;
49-
@Value("${govsso.post-logout-redirect-uri}")
50-
private String postLogoutRedirectUri;
5149

5250
@GetMapping(value = LOGIN_VIEW_MAPPING, produces = MediaType.TEXT_HTML_VALUE)
5351
public ModelAndView clientLoginView(
@@ -89,10 +87,6 @@ public ModelAndView dashboard(@AuthenticationPrincipal OidcUser oidcUser, Exampl
8987
if (locale != null) {
9088
model.addObject("ui_locales", locale);
9189
}
92-
String postLogoutRedirectUri = LogoutUtil.postLogoutRedirectUri(request, this.postLogoutRedirectUri);
93-
if (postLogoutRedirectUri != null) {
94-
model.addObject("post_logout_redirect_uri", postLogoutRedirectUri);
95-
}
9690
}
9791

9892
log.info("Showing dashboard for subject='{}'", oidcUser.getSubject());

src/main/java/ee/ria/govsso/client/govsso/oauth2/GovssoClientInitiatedLogoutSuccessHandler.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,9 @@ private String endpointUri(HttpServletRequest request, URI endSessionEndpoint, S
9797
if (StringUtils.isNotEmpty(locale)) {
9898
builder.queryParam(UI_LOCALES_PARAMETER, locale);
9999
}
100-
if (postLogoutRedirectUri != null) {
101-
builder.queryParam("post_logout_redirect_uri", postLogoutRedirectUri);
102-
}
100+
}
101+
if (postLogoutRedirectUri != null) {
102+
builder.queryParam("post_logout_redirect_uri", postLogoutRedirectUri);
103103
}
104104

105105
return builder.encode(StandardCharsets.UTF_8)

src/main/resources/templates/dashboard.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
<form method="post" th:action="@{/oauth/logout}" id="logoutFormPost">
2626
<input type="hidden" th:id="id_token_hint" name="id_token_hint" th:value="${id_token}">
2727
<input th:if="${ui_locales}" type="hidden" th:id="ui_locales" name="ui_locales" th:value="${ui_locales}">
28-
<input th:if="${post_logout_redirect_uri}" type="hidden" th:id="post_logout_redirect_uri" name="post_logout_redirect_uri" th:value="${post_logout_redirect_uri}">
2928
<input class="btn btn-outline-secondary" name="logout_button" type="submit" value="Log out (POST)"/>
3029
</form>
3130
</li>

0 commit comments

Comments
 (0)