feat: new command for 3D dymint store migration #1302
Conversation
srene
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
==========================================
- Coverage 17.72% 17.29% -0.44%
==========================================
Files 187 195 +8
Lines 55555 58975 +3420
==========================================
+ Hits 9849 10201 +352
- Misses 44182 47183 +3001
- Partials 1524 1591 +67 ☔ View full report in Codecov by Sentry. |
store/storeIface.go
Outdated
| @@ -111,4 +111,6 @@ type Store interface { | |||
| LoadLastBlockSequencerSet() (types.Sequencers, error) | |||
|
|
|||
| Close() error | |||
|
|
|||
| Run3DMigration(da string) error | |||
There was a problem hiding this comment.
not sure it needs to be in the interface.
migration code can cast to DefaultStore and call migration code
store/store.go
Outdated
| @@ -423,6 +424,79 @@ func (s *DefaultStore) LoadLastBlockSequencerSet() (types.Sequencers, error) { | |||
| return sequencers, nil | |||
| } | |||
|
|
|||
| func (s *DefaultStore) Run3DMigration(da string) error { | |||
There was a problem hiding this comment.
not sure why it's Store's method
probably should be some migration code in block/
migration cmd has both store and db (store.NewPrefixKV(baseKV, mainPrefix))
There was a problem hiding this comment.
I've moved it to a standalone func
block/slvalidator.go
Outdated
| // skip validation for DRS version 0 (2D rollapps) | ||
| if version == 0 { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
gonna merge for now but need some reasoning why this is OK
There was a problem hiding this comment.
i think we need to skip drs validation for previous to migration blocks, because in case blocks were received via p2p previous to the migration, when is trying to validate them it will fail to find drs info on store. i replaced this check by only logging error when drs version info is not found (cannot be considered fraud, so i think is fine).
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #1301
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: