Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move retrieving blocks from blocksync logic from p2p client to block manager #1260

Open
srene opened this issue Nov 28, 2024 · 2 comments
Open

move retrieving blocks from blocksync logic from p2p client to block manager #1260

srene opened this issue Nov 28, 2024 · 2 comments

Comments

@srene
Copy link
Contributor

srene commented Nov 28, 2024

this way, there can be a better handling of the blocks received and whether we need to stop retrieving blocks because a fork happened or the node is frozen.
@danwt
Copy link
Contributor

danwt commented Jan 7, 2025

Seems like a nice to have but not urgent? Wdyt @srene ?

@srene
Copy link
Contributor Author

srene commented Jan 8, 2025

its just a code improvement.
also some refactor can be done to optimize how blocksync blocks are retrieves (are is just a simple iterating request and caching through all pending blocks).
but i agree its not urgent. probably can be done with future dymint syncing architecture refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srene @danwt