Remove duplicate code in tool-interface #1539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no semantic changes here
Note that the duplicated (now removed) code, particularly read-file-header-component, stopped at the first blank line, just as the function by the same name in file-source-records does, even though project files don't (I think?) have a non-header part. Potentially we could add a skip-blank-lines? option to read-file-header. But in any case, I believe the new code is consistent with the old code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three stage bootstrap succeeds.
Definitely look at the whitespace diff and the substantive diff as separate commits, not the merged diffs in the GitHub UI.