Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make run-application API consistent on Windows #1504

Open
cgay opened this issue Jun 19, 2023 · 1 comment
Open

Make run-application API consistent on Windows #1504

cgay opened this issue Jun 19, 2023 · 1 comment

Comments

@cgay
Copy link
Member

cgay commented Jun 19, 2023

In b190938 I changed run-application on unix system to not require a limited collection of strings because it makes the API more difficult to use. Do the same for Windows.

@cgay
Copy link
Member Author

cgay commented Jun 20, 2023

It looks like run-application on Windows doesn't work with a sequence of strings at all, which makes sense since neither does the win32 CreateProcessA API as far as I can see.

Assuming my reading of the above is correct, we have choices:

  1. Change run-application on Windows to accept <sequence> and raise a friendly error if a non-<string> argument contain any non-<string> elements. Convert the sequence to a string with join(seq, " "). (Let's assume we'll ignore issues of ensuring command arguments are quoted.)
  2. Change run-application on Windows to accept <string> only and document that in order to be cross-platform users should pass a string to run-application.

cgay added a commit to cgay/opendylan that referenced this issue Jun 24, 2023
cgay added a commit to cgay/opendylan that referenced this issue Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant