Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site updates, sidenav responsive behaviour fixed & opinionated button token fixed #2113

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Nov 5, 2024

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Updates:

  • Edit page links fixed. They were pointing to non-existing files.
  • Sidenav's responsive behaviour inside the application layout has been fixed.
  • Button updates in the opinionated theming strategy to fix color contrast issues.
  • Themes page has been updated with the latest values.
  • Typescript configuration updates and simplification.
  • Type fix in the Toast component at the loading method.

Closes #2105

@GomezIvann GomezIvann marked this pull request as ready for review November 5, 2024 16:05
@GomezIvann GomezIvann changed the title Site broken links updated & sidenav responsive behaviour fixed Site updates, sidenav responsive behaviour fixed & opinionated button token fixed Nov 7, 2024
@Mil4n0r Mil4n0r self-requested a review November 8, 2024 13:42
@Mil4n0r Mil4n0r self-assigned this Nov 8, 2024
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Mil4n0r Mil4n0r merged commit ed41d64 into master Nov 11, 2024
4 checks passed
@Mil4n0r Mil4n0r deleted the gomezivann/site-broken-links branch November 11, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled Button Not Visible in Bloom Theme After Upgrade to Halstack Version 14
2 participants