Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong specifications images of several components #1733

Open
Jialecl opened this issue Nov 15, 2023 · 3 comments
Open

Wrong specifications images of several components #1733

Jialecl opened this issue Nov 15, 2023 · 3 comments
Labels
guidelines inconsistency jira This task is referenced in a story of Jira non-closable This task is exempt from becoming stale or automatically closed.

Comments

@Jialecl
Copy link
Collaborator

Jialecl commented Nov 15, 2023

There are several components with wrong specs images:

  • Date input:

Some of the values used in this image are incorrect. For example the font size values for the years.

image

  • Dropdown:

Gap between icon and option text is marked in the spec image but it not marked as 10px.

image

  • Header:

Header component has no divider and application name by itself. They are part of the content. We should remove them from the header image specs since it could cause misunderstandings.

image

  • Paginator:

Vertical padding of 12px is missing.

image

  • Slider:

Text input is the old one.

image

  • Tabs:

When enabled but no selected tab, the font size is grey, not purple.

image

@raquelarrojo raquelarrojo changed the title Date picker dialog spec images does not have the correct values Wrong specifications images of several components Nov 21, 2023
Copy link

github-actions bot commented Feb 7, 2024

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

@github-actions github-actions bot added the stale This task has no activity and will be closed within 15 days. label Feb 7, 2024
@kukoc kukoc added the jira This task is referenced in a story of Jira label Feb 7, 2024
@github-actions github-actions bot removed the stale This task has no activity and will be closed within 15 days. label Feb 8, 2024
Copy link

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

@github-actions github-actions bot added the stale This task has no activity and will be closed within 15 days. label Feb 24, 2024
@Mil4n0r Mil4n0r added non-closable This task is exempt from becoming stale or automatically closed. and removed stale This task has no activity and will be closed within 15 days. labels Feb 27, 2024
@rconcepcion3
Copy link
Collaborator

Attaching the updated specifications images. Here are the details by updated image:

  • Date input: updated specifications for font sizes with updated ones
  • Dropdown: added 10px distance specs between icon and text
  • Header: removed divider and application name in the specs image
  • Paginator: vertical padding specs above and below added
  • Slider: 2 images (specs and anatomy) both with updated text input fields
  • Tabs: updated states and state names. The text on the site also needs to be changed. We no longer use 'pressed' state. Here is the new text to use:

Tabs have different states based on the user interaction. These states include: enabled, hover, focus, active, disabled, and inactive.
specifications_images.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidelines inconsistency jira This task is referenced in a story of Jira non-closable This task is exempt from becoming stale or automatically closed.
Projects
None yet
Development

No branches or pull requests

4 participants