Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disabled in chip should only affect to the icon #1707

Open
raquelarrojo opened this issue Oct 13, 2023 · 3 comments · Fixed by #1943
Open

disabled in chip should only affect to the icon #1707

raquelarrojo opened this issue Oct 13, 2023 · 3 comments · Fixed by #1943
Assignees
@raquelarrojo
Labels
enhancement New feature or request jira This task is referenced in a story of Jira non-closable This task is exempt from becoming stale or automatically closed.

Comments

@raquelarrojo
Copy link
Collaborator

Describe the bug
At the moment, the chip can be disabled even it there is no action icon. It has no sense to be disabled since there is no interaction with it.

Expected behaviour
The disabled should only affect to the action icon.

Screenshots
image
@raquelarrojo raquelarrojo changed the title disabled in chip should only affect to the action icon. disabled in chip should only affect to the action icon Oct 13, 2023
@raquelarrojo raquelarrojo added the enhancement New feature or request label Oct 13, 2023
@GomezIvann GomezIvann mentioned this issue Feb 5, 2024
Open
@kukoc kukoc added the jira This task is referenced in a story of Jira label Feb 7, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

@github-actions github-actions bot added the stale This task has no activity and will be closed within 15 days. label Feb 23, 2024
@Mil4n0r Mil4n0r added non-closable This task is exempt from becoming stale or automatically closed. and removed stale This task has no activity and will be closed within 15 days. labels Feb 27, 2024
@raquelarrojo raquelarrojo self-assigned this Mar 7, 2024
@raquelarrojo raquelarrojo changed the title disabled in chip should only affect to the action icon disabled in chip should only affect to the icon Mar 12, 2024
@raquelarrojo raquelarrojo linked a pull request Apr 10, 2024 that will close this issue
Several fixes in the Chip #1943
Merged
5 tasks
@raquelarrojo raquelarrojo mentioned this issue Apr 10, 2024
Merged
5 tasks
@Mil4n0r Mil4n0r removed the non-closable This task is exempt from becoming stale or automatically closed. label Apr 17, 2024
@raquelarrojo raquelarrojo reopened this Apr 18, 2024
@raquelarrojo
Copy link
Collaborator Author

raquelarrojo commented Apr 18, 2024 •
edited
Loading

Fix available here:
https://github.com/dxc-technology/halstack-react/tree/rarrojolopez/chip-fixes
https://github.com/dxc-technology/halstack-react/tree/rarrojolopez/chip-specs

It has been reverted to avoid creating a breaking change.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

@github-actions github-actions bot added the stale This task has no activity and will be closed within 15 days. label May 4, 2024
@Mil4n0r Mil4n0r added non-closable This task is exempt from becoming stale or automatically closed. and removed stale This task has no activity and will be closed within 15 days. labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raquelarrojo raquelarrojo

Labels
enhancement New feature or request jira This task is referenced in a story of Jira non-closable This task is exempt from becoming stale or automatically closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Several fixes in the Chip dxc-technology/halstack-react
3 participants
@kukoc @raquelarrojo @Mil4n0r