Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items are overlapped in some cases which provides incorrect results sometimes #334

Open
AdityaRawat96 opened this issue Sep 19, 2022 · 2 comments

Comments

@AdityaRawat96
Copy link

Hi @dvdoug,

I loved the BoxPacker that you created and it seems to be working fine most of the times but in certain test cases I have observed that the items are not correctly stacked which results in inconsistent results.

I compared the results with the bin packer provided by - https://www.3dbinpacking.com which shows the 3D representation of packed items and below are the parameters that I used.

image

As you can see it packs the 18 items in a single medium box but when I try the same with BoxPacker implementation the items are packed in a medium (15 items) and a small box (3 items).

image

To further debug the issue I mapped the items from medium box into 3D cubes using threeJS and below are my findings -

image

As you can see some of the items are overlapping and not stacked correctly. You can check my implementation demo here -
https://clarteresearch.com/projects/BoxSizeCalculator3D/

Here is the repo for the above demo -
https://github.com/AdityaRawat96/BoxSizeCalculator

Thanks!

@dvdoug
Copy link
Owner

dvdoug commented Sep 25, 2022

Hi @AdityaRawat96

I'll take a look, seems to be case of the first item being placed in a different orientation, and then everything else being a knock-on consequence of that.

Hopefully 🤞 this one should be fairly straightforward, as all items have the same dimensions so there's no issue around sorting, only placement

@earbor-ai
Copy link

Hi @dvdoug,

Did you had any suggestion here or fix? Having the same issue for us too..

Thanks

dvdoug added a commit that referenced this issue Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants