From 30aaef1efd80bda4774603b69f587e1a6850f2d5 Mon Sep 17 00:00:00 2001 From: Doug Wright Date: Sun, 15 Sep 2019 18:41:21 +0100 Subject: [PATCH] Optimise the rebuild further for the legacy data structure --- src/VolumePacker.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/VolumePacker.php b/src/VolumePacker.php index 10805960..791e8f73 100644 --- a/src/VolumePacker.php +++ b/src/VolumePacker.php @@ -381,8 +381,9 @@ protected function checkDimensionalConstraints(Item $itemToPack) */ protected function rebuildItemList() { - $this->items = ItemList::fromArray(array_merge($this->skippedItems, iterator_to_array($this->items))); - $this->skippedItems = []; + while(count($this->skippedItems)) { + $this->items->insert(array_pop($this->skippedItems)); + } } /**